Added "or" condition processing to validation parameters #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added orConditions. Added validation tests.
|
Note: This additionally has test reporting and working unit tests for the old and new behaviour. TODO: Implement mixing of "or" and "and" condition logic. This would include something like... (isEmpty|isEmail)&(isEmpty|isMobilePhone) |
|
Please see issue #25 for a description of the original issue. |
|
This is covered by PR #54. A new single syntax to handle this and injecting parameters into the new Validator update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new format for handling "or" conditions. Specifically this would be written as
<ValidatedInput id="profile-companyMail" name="companyMail" type="email" placeholder="Email" validate="isEmpty|isEmail" errorHelp="Incorrect Email" />The above would validate a non-required email field.